Cv2 5861 fix openai embeddings #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGaffney
requested review from
computermacgyver and
skyemeedan
as code owners
computermacgyver
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are currently sending requests to encode OpenAI-based vector embeddings via Presto - instead we need to do those internally on Alegre on the backside of the encoding callback process. All that's needed I believe is to just prevent these from being sent to Presto in the first instance.
Reference: CV2-5681
How has this been tested?
Not yet tested locally, new tests have been added to cover the regression
Have you considered secure coding practices when writing this code?
None relevant